search

web-platform-tests / interop

web-platform-tests Interop project
https://wpt.fyi/interop
278 stars 28 forks source link

Review recent changes to Custom Properties tests #587

Closed foolip closed 10 months ago

foolip commented 10 months ago

Test List

https://wpt.fyi/results/css/css-properties-values-api/at-property-cssom.html https://wpt.fyi/results/css/css-properties-values-api/at-property.html

These tests were updated in https://github.com/web-platform-tests/wpt/pull/42500 and there's some discussion in https://github.com/w3c/css-houdini-drafts/issues/1098.

The changes have already been made. This introduced test failures in Chrome and Safari.

cc @fred-wang @emilio @lilles

Rationale

No response

foolip commented 10 months ago

cc @andruud

emilio commented 10 months ago

@foolip this was discussed in https://github.com/web-platform-tests/interop/issues/575, right? What am I missing?

foolip commented 10 months ago

@emilio you're not missing anything, I am, I forgot about that issue and didn't go searching.

I'll close this and hide comments elsewhere.

fred-wang commented 10 months ago

WebKit has an approved PR to make these tests pass again: https://github.com/WebKit/WebKit/pull/19050

emilio commented 10 months ago

Okay, let's close this then.