Closed fred-wang closed 10 months ago
The change looks straightforward and uncontroversial to me.
@lilles @andruud Can you review this for Chromium?
cc @emilio
Changing https://wpt.fyi/results/css/css-properties-values-api/property-cascade.html to use getComputedStyle for color lgtm.
Yeah sounds good to me fwiw. Thanks Fred!
Test List
https://wpt.fyi/results/css/css-properties-values-api/property-cascade.html
Rationale
The following tests from
css-properties-values-api
rely on thecomputedStyleMap()
API from CSS Typed OM Level 1, which is being proposed for interop 2024 in #490:The two first are really testing the Typed OM spec with registered properties and are not labelled for interop 2023, so that's fine. However, the last one is included in interop 2023 and fails in Firefox, (which does not implement the
computedStyleMap()
API yet):https://wpt.fyi/results/css/css-properties-values-api?q=label%3Ainterop-2023-property
Checking
property-cascade.html
in more details,computedStyleMap()
is really only used to get the computed value of sRGB colors, which have the same used and resolved values. SogetComputedStyle()
can just be used instead.(After doing that, WebKit and Chrome still pass the tests, while Firefox Nightly really fails because of it violates the actual assertion being tested)