search

web-platform-tests / wpt.live

A live version of the web-platform-tests project
https://wpt.live/
15 stars 11 forks source link

Mismatch in service-port declaration between terraform and WPT config #33

Open stephenmcgruer opened 4 years ago

stephenmcgruer commented 4 years ago

src/wpt-config.json.template has:

  "ports": {
    "http": [80, 8000],
    "https": [443, 8443],
    "ws": [8001],
    "wss": [8002],
    "http2": [8003]
  },

Whilst infrastructure/web-platform-tests/main.tf has:

  service_port_1      = 80
  service_port_1_name = "http-primary"
  service_port_2      = 8000
  service_port_2_name = "http-secondary"
  service_port_3      = 443
  service_port_3_name = "https"
  service_port_4      = 8001
  service_port_4_name = "http2"
  service_port_5      = 8002
  service_port_5_name = "websocket"
  service_port_6      = 8003
  service_port_6_name = "websocket-secure"

I don't think this has any semantic impact since the terraform config is just exposing the ports, but technically per wptserve 8001 should be "websocket", 8002 should be "websocket-secure", and 8003 should be "http2".