[fix] Refactor navBarItems

adrianvrj commented 1 month ago

This issue will be part of ODHack9.0, please apply via Onlydust app

This is a frontend issue, knowledge in Nextjs is recommended.
Currently we are using a constant to set the navbar items in every single page, this constant appears in every single component that needs the navbar.
Create a new constant on the constants directory with the values for the navbar items.
Refactor each component that uses the navItems to use the constant created.
Please read contributors guide before asking for an issue.

PoulavBhowmick03 commented 1 month ago

I'd like to take it up

I'm Poulav Bhowmick, a Starknet Wolf. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum, Stellar ecosystem.

Approach

I will be creating a centralized constant for the navbar items within the gostarkme/-web/constants file. I will allow all components to reference the same set of navbar items. And then will refactor each component to import and use this new constant instead of defining it locally.

Eta - 1 day

Iwueseiter commented 1 month ago

Could I take over this issue? I'm a frontend and smart contract developer. I will create a navbar and refactor every component that uses the navitem to use the constant I'd create. I will make it responsive and make sure it functions as expected. This will be my first time contributing to this project and I'm looking forward to working. ETA: 24hrs

SoarinSkySagar commented 1 month ago

My background: I am a full stack web developer with 3 years of experience in TS and JS, and 2 years specifically with Next.js Approach: I would create a new constant in the frontend/gostarkme-web/constants/index.ts, and then I will refactor each component to import the constant from that file and use it.

Would love to take up this issue! ETA: 16 Hours

TEMHITHORPHE commented 1 month ago

Could I be assigned to this? Template: Hi, I'm Temi and I'll be working on issue #163

I estimate this will take 30 minutes to complete.

This is how I would tackle this issue: I'll declare the constants value in the constants file (will create if it doesn't exist), this ensures we have a single source of truth, helps simplify future refractors.

wheval commented 1 month ago

Can I handle this task? ETA is 1 day.

Benjtalkshow commented 1 month ago

I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 31 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.

Currently, the navigation bar items are individually set in each pages (myfunds/page.tsx, myprofile/page.tsx, app/page.tsx) that uses them, with code that defines navItems like this:

const navItems = [ { label: 'My Profile', href:/app/myprofile}, { label: 'My Funds', href:/app/myfunds} ];

To address this, I plan to centralize the navItems constant within the constants directory, specifically in constants/index.ts, so that all components can reference the same constant without redefining it locally. Each component will import navItems from this single source, reducing repetition, ensuring consistency, and making future updates simpler and more maintainable.

This will be my first contribution to this amazing project, and I’m excited to apply my skills to enhance the code structure and efficiency in this way. Once implemented, I’ll thoroughly test the refactor to confirm the navigation bar functions as expected across all components. My ETA is 5hrs when the task is assigned to me. Thanks

mimisavage commented 1 month ago

Can I take care of this issue?

LazarusAA commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I'm Alvaro Lazarus a new member of Dojo Coding, im relativley new to blockchain but I recently worked on a project for a Hackathon where I used Nextjs extensively which makes me confident that I can complete this issue.

How I plan on tackling this issue

Id move navbar items to a single constant in the constants directory.
And update all components to reference the new constant for navbar items.

Please consider

ETA: 24 hrs

GradleD commented 1 month ago

Would love to tackle this! I am going to commit directly on github

Akshola00 commented 1 month ago

May I handle this issue?

FemiOje commented 1 month ago

I am applying to this issue via OnlyDust platform.

Hi, I'm jinius and I'll be working on issue #163.

I estimate this will take 3 hours to complete.

This is how I would tackle this issue:

create new const named navItems in frontend/gostarkme-web/constants/index.ts
populate const with all needed navbar labels/links.
remove hardcoded navItems const from all components importing Navbar(eg frontend/gostarkme-web/components/ui/Bounded.tsx), and replace with navItems in frontend/gostarkme-web/constants/index.ts
test for functionality and responsiveness.

web3wagers / gostarkme