web3wagers / gostarkme

Fund raising project in Starknet ecosystem
http://web3wagers.github.io/gostarkme/
GNU Affero General Public License v3.0
18 stars 74 forks source link

[test] Add test for new assert in set_goal method #258

Closed EmmanuelAR closed 2 hours ago

EmmanuelAR commented 1 week ago

This issue will be part of ODHack10, please apply via Onlydust app

Chukwuemeka-James commented 1 week ago

Hi, I'm James and I'll be working on issue #258.

I estimate this will take 20hrs to complete.

I will ensure the test covers the following: test_admin1_can_set_goal test_admin2_can_set_goal test_owner_cannot_set_goal test_random_user_cannot_set_goal test_sequential_goal_updates test_goal_edge_values

I will define the following helper Functions: setup_addresses: Creates test addresses for different roles setup_fund_contract: Initializes contract state for testing

BrunoAmbricca commented 1 week ago

I would like to work on this issue

Emmanex01 commented 1 week ago

Can I take this issue?

Gerson2102 commented 1 week ago

Hey! I'm Gerson. đź‘‹

Member of Dojo Coding. I have contributed before to other projects like:

Can I work on this issue?

Check my OnlyDust profile, I've contributed to many projects: Profile


Plan to Solve the Issue:

  1. Study the codebase to understand the current structure and functionality.
  2. Understand the problem that needs to be solved by thoroughly reading the issue details.
  3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
  4. If I encounter roadblocks, I will ask questions ASAP in the Telegram group to move forward effectively.
  5. I will open a PR and wait for ur feedback

No-bodyq commented 1 week ago

Hi, I'm Asher and I'll be working on issue #258.

I estimate this will take >24hrs to complete.

This is how I would tackle this issue:

Go through and understand the set goal method being tested and write test for the new assert, taking into account any edge cases

Unickhub commented 1 week ago

Is it okay if I take this?

mimisavage commented 1 week ago

I'd like to handle this task.

ncoquelet commented 1 week ago

Is this issue still available?

Presentation

Hello, I'm senior developer, comfortable with Typescript, React/Vite/Next, testing, CI/CD, docs and I'm a beginner on Cairo (starklings 100% and NodeGuardians “Entering Cairo”, “Thinking in Cairo”, “Vanity Address”, and I continue). I'm rigorous and diligent, I'm used to contributing my skills to projects and can move really quickly.

How do I resolve this issue?

I will Implement specifications.

Contributors guide checked !

GideonBature commented 1 week ago

Can I be assigned to this?

My name is Gideon Bature, a Software Engineer with experience building Starknet based smart contracts, using Cairo. If given this issue, I should be able to send my first PR within 48 hrs right after issue #254 is completed.

Thank you!

Benjtalkshow commented 1 week ago

Can I take this issue?

ryzen-xp commented 1 week ago

Hi, I am proficient Blockchain developer expert in Cairo , Rust and Solidity and also in web development. I have contributed many stark net project and more . To tackle this issue, I will: ==>

  1. Add a test for the new assert in the set_goal method.
  2. Ensure the test verifies the correct behavior of the assert under various conditions.
  3. Handle edge cases and potential failure scenarios for thorough testing.
    please /assign this issue . Thank You
ShantelPeters commented 1 week ago

I'd like to take this issue.

Michaelkingsdev commented 1 week ago

May I take care of this?

SoarinSkySagar commented 1 week ago

May I work on this issue once the mentioned issue is resolved, @EmmanuelAR?

I am an experienced cairo dev and a regular contributor at @keep-starknet-strange.

eta: 3 days

akintewe commented 1 week ago

Hello can i be assigned this issue, i am a new contributor with experience in Cario and typescript, would love to work on this , my ETA is >24 Hours and ill create a draft PR in 17 hours time. Thank you for this opportunity. :)

Kom02 commented 1 week ago

Hi, My name is Kevin Obando, a full stack junior developer with 2 years of experience from Costa Rica. I am starting in this community and I want to help in this project.

NueloSE commented 1 week ago

I’m interested in this one.

I will ensure the test covers the following: test_admin1_can_set_goal test_admin2_can_set_goal test_owner_cannot_set_goal test_random_user_cannot_set_goal test_sequential_goal_updates test_goal_edge_values

Am experienced in writing and testing smart contract using cairo. ETA <= 24hrs

Supa-mega commented 1 week ago

May I pick this up?

ikezuby2012 commented 1 week ago

hello, can i be assigned this issue?

my name is nnubia nzube, i'm a software developer with experience in writing smart contract using cairo, i would like to write the test for the contract, my ETA is within 48 hours.

saimeunt commented 1 week ago

Hey, I'm a returning contributor having previously worked on testing gostarkme, I think this can be completed in half a day.

Gianfranco99 commented 1 week ago

Hello, I can solve this issue easily, I have already been contributing to this project and I would like to continue being part of it!

petersdt commented 1 week ago

Mind if I take this issue?

Experienced in testing and writing proveable smart contract using cairo and solidity.

For the above task based on the implementation from issue#254 i would implement a uint test to cover all necessary edge case with the implementation of set_name method.

this would be nice to have

tnv1 commented 1 week ago

I'd like to handle this task. Thank you!

mimiprosper commented 1 week ago

Let me try this one! Am a web 2 frontend developer, a solidity smart contract developer/auditor and a cairo smart contract developer. Am a graduate of Starknet Cairo Bootcamp. I have successfully done tasks assigned to me in OnlyDust. If assigned this i would complete it within 4 days.

bruhhgnik commented 1 week ago

i can do this, eta: 24 hours

wheval commented 1 week ago

I’d like to resolve this.

hossamanany commented 1 week ago

Can I take this from here?

Thibrac commented 1 week ago

I'd like to take this issue.

Aditya-040 commented 6 days ago

May I be assigned to this?

renzobanegass commented 6 days ago

Hi! I have been assigned issues on this project before but couldn't complete it, would love to give it a try again. I'm a Software Developer with over 5+ years of experience and a member of Dojo Coding, I think I can provide a fast PR as soon as the #254 issue is done

Rayguti commented 6 days ago

Why I’m Interested: With experience in smart contract development and testing, I am eager to contribute to ODHack10.0 by adding meaningful tests to the project. This issue provides an excellent opportunity to refine my skills in Cairo and collaborate with the Onlydust community. My background in writing structured and reliable test cases ensures I can effectively deliver this feature while maintaining high-quality standards.

Proposed Approach:

Review Dependencies:
    Examine changes introduced in issue #254 to understand the updates in the set_goal method.
    Analyze the behavior and expected outcomes of the assert_admins function.

Design Test Cases:
    Develop test scenarios to verify:
        Proper functionality when valid admins are involved.
        Handling of unauthorized users or invalid admin roles.
        Edge cases, such as boundary conditions for admin privileges.

Implementation:
    Use Cairo’s testing framework to write and run the new test cases.
    Ensure the tests align with the structure and conventions of the project’s existing test suite.

Validation:
    Run tests in different scenarios to validate the robustness of the assert_admins functionality.
    Ensure meaningful error messages and debug information are included for failed cases.

Collaboration:
    Coordinate with contributors of issue #254 to ensure a seamless handoff.
    Follow up with maintainers for feedback on test implementation.

Outcome: A robust and comprehensive test for the assert_admins function will be added to the set_goal method, ensuring reliability and proper functionality of the feature.

abdegenius commented 5 days ago

I'd love to give this a go.

adrianvrj commented 1 day ago

hi @renzobanegass any updates on this? :)

renzobanegass commented 1 day ago

Hi! @adrianvrj I'll be creating a PR today