[WIP] Remove recipe which overlay other recipes in upper layers

[Herrie82]

@tofee lgvl is used for your PP recovery no? I have no objections in general, however I didn't build test this at my end yet for PPP.

[shr-project]

I think this was WIP and more changes were needed as discussed with Tofee on IRC, let me check the history.

[Herrie82]

I'm getting this for PPP while building: /lv_conf.h: No such file or directory | 41 | # include "../../lv_conf.h" /Else assume lv_conf.h is next to the lvgl folder/

[shr-project]

2022-02-22:

10:37 < Guest7223> Tofe: do you have a sec to discuss lvgl?
10:37 < JaMa> it's me :)
10:37 < Tofe> Guest7223/JaMa: a bit later maybe ? I'm out for lunch in a couple of minutes
10:39 < Guest7223> sure
11:30 < Tofe> JaMa: ping
11:33 < JaMa> was the recipe in meta-pine64 imported from some other layer?
11:34 < JaMa> the build issue I've seen yesterday with the meta-oe recipe was just the lv_conf.h location where your recipe correctly installs it directly in includedir while meta-oe recipe creates lv_conf.h from the template (with 2 sed replacements) but then installs it into includedir lvgl (where it's not found by lvgl)
11:35 < Tofe> JaMa: good question, not sure about that... 
11:35 < Tofe> I think so
11:35 < JaMa> and after fixing the location there are many more build error https:dpaste.comYT9R76QV possibly due to API changes in version 8
11:35 < Guest7223> https://dpaste.com/3YT9R76QV
11:36 < Guest7223> sigh the other irssi client refuses to type '/' even when copy&pasting a link.. what's going on :/
11:36 -!- JaMa is now known as Guest889
11:36 -!- You're now known as JaMa
11:36 -!- Guest889 [~martin@78.80.214.103] has quit [Remote host closed the connection]
11:37 < JaMa> as well as main.c:2:10: fatal error: lv_drivers/display/fbdev.h: No such file or directory
11:37 < JaMa> the meta-oe recipe is using gitsm:// so in theory the drivers from submodule should be installed as well
11:38 < Tofe> ah, could be lvgl dropped fbdev ?
11:38 < JaMa> on the other hand I've noticed that your recovery-ui defines lvgl as submodules as well
11:38 < JaMa> was it for easier development locally as I don't think it's checked out by bitbake during recovery-ui build
11:39 < Tofe> Yes,  it was much easier that way, and I could also play with it on desktop
11:39 < JaMa> https://github.com/lvgl/lv_drivers/blob/master/display/fbdev.h still exists
11:40 < Tofe> ah, good :)
11:40 < JaMa> but the meta-oe recipe doesn't do anything to install these headers (I haven't checked if CMake is supposed to do it automatically when gitsm:// checks out the module)
11:41 < JaMa> https://git.openembedded.org/meta-openembedded/commit/?id=21580d65af95a854cccc7d0bf5c31201c9c30ea9
11:42 < JaMa> and I don't know how much you customized lv_conf.h from the template as it was in version 6, the meta-oe recipe adds separate variable to control LV_MEM_CUSTOM
11:42 < JaMa> hmm and there used to be EXTRA_OECMAKE += "-Dinstall:BOOL=ON"
11:42 < JaMa> https://git.openembedded.org/meta-openembedded/commit/?id=b6738f86f3dd1d5208abdb455d10f9d16e198dd2
11:43 < JaMa> so long story short as you wrote recovery-ui, when you have some spare moments can you check the migration to lvgl 8? :)
11:43 < Tofe> JaMa: yes, I'll do the migration :)
11:44 < JaMa> as even if I get it building I won't be able to test it, so better you do both and I concentrate on some other build issues
11:44 < JaMa> ok, thanks :)
11:44 < Tofe> It isn't a very mature component yet, so lots of stuff is quite naïve
11:45 < JaMa> but the documentation online looked much better than expected
11:54 < Tofe> yes, it's a quite nice toolkit actually

[Tofee]

Migrating to a newer LVGL version will be a bit of work, so just removing the recipe version won't help much here

[shr-project]

Merged though https://github.com/webOS-ports/meta-pine64-luneos/pull/33 and apitrace from here.