webalys-hq / streamlinehq-npm

The deprecated Streamline NPM package, which will be deleted on 1st November 2022.
https://medium.com/streamline-icons/how-streamline-narrows-down-its-focus-eac6fdb5c6f2
24 stars 5 forks source link

Some icons are blank #44

Closed thnee closed 3 years ago

thnee commented 3 years ago

There seems to be a bug. All files matching @streamlinehq/streamlinehq/img/streamline-light/money-payments-finance/modern-payments/cashless-* are just blank, whereas other files in the same directory and other directories are not.

The way I have tested this is simply by opening them in google-chrome and for those broken files, there is nothing but white on the screen, whereas with other files, the icon is visible.

cbrwizard commented 3 years ago

Hey, thank you for reporting this, we will investigate and let you know

marckorz commented 3 years ago

Stumbled on the same error while importing 'EjectButton' in combination with the @svgr/webpack module. (import EjectButton from '@streamlinehq/streamlinehq/img/streamline-light/interface-essential/on-off/eject-button.svg';)

In order to fix the error you have to add the stroke prop in the corresponding svg-files: stroke="currentColor"

FelixSab commented 3 years ago

I got the same issue with import Earth3 from '@streamlinehq/streamlinehq/img/streamline-regular/maps-navigation/earth/earth-3.svg';

It works fine locally, but the icon is blank when deployed. stroke="currentColor" does fix that though

cbrwizard commented 3 years ago

We have confirmed it on our end as well and will work on it. Thank you for patience!

onhate commented 3 years ago

the same for @streamlinehq/streamlinehq/img/streamline-light/design/colors-painting/color-painting-palette.svg

ghost commented 3 years ago

@cbrwizard What's the status on this? It's been 45 days since it was reported and 14 days since you've acknowledged the issue.

cbrwizard commented 3 years ago

Thank you for your patience. Unfortunately, we're a small team and we're limited in what we can work on. Please consider copying svgs directly from our website, it should work more reliably than the npm package.

onhate commented 3 years ago

Looks like it's just missing a stroke="currentColor" on the <svg tags, don't have the same source of files for the npm packages?

thnee commented 3 years ago

@cbrwizard Would be really good with a status update here, since it has been 3 months without any info. I appreciate that you are a small team, and really appreciate the format of delivery and support that you provide in this git repo. But we did pay money for this, and it is a standard expectation for an icon library to have some kind of package available, and not have to manually copy individual files for every icon. Seems like it should be an easy fix, what's the holdup?

cbrwizard commented 3 years ago

Considering the number of issues with npm package I'd strongly suggest avoiding using it and relying on getting the images from the website directly. Without npm package Streamlime team will be able to spend more time on features which are really needed for customers and you will have always working images. I understand that this is not the answer you've been hoping for and I'm sorry for that. We'll write a more detailed update on this in the foreseeable future.

cbrwizard commented 3 years ago

Today we announce that we're deprecating the Streamline NPM package. Instead, we’ll focus on the web app and Figma plugin, which are used by a noticeable share of our customers.

Please from now on instead of using our brittle package download the images directly from our website and insert them into your project as SVG files. Meanwhile, Streamline team is focused on ensuring that our web application provides the best user experience for developers' use cases. Please take 2 minutes to share feedback so that we can improve.

We'll keep this package with minimal life support until 1st November 2022, after which it's going to be deleted.

Please read the full story in this article.