webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
741 stars 63 forks source link

www.google.com - Unable to sign in to view/book flights #37176

Closed webcompat-bot closed 4 years ago

webcompat-bot commented 5 years ago

URL: https://www.google.com/flights?f=1#f=1&flt=/m/04jpl..2019-08-21*./m/04jpl.2019-08-25;c:GBP;e:1;sd:1;t:s&spf=1565016700595

Browser / Version: Firefox Mobile (Tablet) 68.0 Operating System: Android 10.0.0 Tested Another Browser: No

Problem type: Something else Description: Sign in button isn't working Steps to Reproduce:

Screenshot Description

Browser Configuration
  • mixed active content blocked: false
  • image.mem.shared: true
  • buildID: 20190804100037
  • tracking content blocked: false
  • gfx.webrender.blob-images: true
  • hasTouchScreen: true
  • mixed passive content blocked: false
  • gfx.webrender.enabled: false
  • gfx.webrender.all: false
  • channel: nightly

Console Messages:

[u'[JavaScript Warning: "Ignoring preventDefault() call on event of type touchstart from a listener registered as passive." {file: "https://www.google.com/xjs/_/js/k=xjs.qs.en_GB.bqvClTKrst0.O/ck=xjs.qs.1o212cb63fvzs.L.F4.O/am=AAAALELIAIAJhwAjwJoAAEUETWk_AMAJQEAUAAAAAg/d=1/exm=bZNvGe,csi,d,dbm,hsm,jsa,mad,nraMcf,r/ed=1/dg=2/ct=zgms/rs=ACT90oEU7p76toqQ6Oh2BHdClQdBWc-AWw/m=DDQlpe,WEuwzf,aa,async,dvl,fs,gJXeyb,mUpTid,mu,sf,vs?xjs=s2" line: 4820}]']

From webcompat.com with ❤️

softvision-oana-arbuzov commented 5 years ago

Thanks for the report, I was able to reproduce the issue. Nothing happens when tapping "Sign in" button.

Note: Not reproducible on Chrome where I'm redirected to Sign in page.

Tested with: Browser / Version: Firefox Nightly 68.0a1 (2019-08-05) Operating System: Sony Xperia Z2 (Android 6.0.1) - 1080 x 1920 pixels (~424 ppi pixel density)

Moving to Needsdiagnosis for further investigation.

ksy36 commented 5 years ago

This is UA detection, Firefox receives a different template and different js files:

So in this file :

q_Ijh.then(function (c) {
        if (c.isAvailable()) {
          var d = {
            ay: a
          };
          b && b['continue'] && (d.P5b = b['continue']);
          c.Nwa(d)
        }
})

When tracing down c.isAvailable(): For Firefox in here it's:

  q_wXa.prototype.isAvailable = function () {
    return !1
  };

And for Chrome here:

q_gXa.prototype.isAvailable=function(){
   return!0
};

Since for Firefox isAvailable returns false, c.Nwa(d) never gets executed (this function seems to be the one responsible for redirecting to the auth page in Chrome's version).

For Firefox seems like c.Nwa(d) is triggering an error:

    q_wXa.prototype.Nwa = function () {
      q_2n('sis', 'ca', '1', q__n())
    };

    var q_Zn = function (a, b, c) {
      b = Error.call(this, a + ':' + (b ? ' ' + b : '') + (c && c.message ? ' ' + c.message : ''));
      this.message = b.message;
      'stack' in b && (this.stack = b.stack);
      this.$ = a
    };
    q_e(q_Zn, Error);
    var q_aXa = function (a) {
      return new q_Zn(0, 'pk`' + a)
    },
    q__n = function () {
      return new q_Zn('unknown_error', 'rk')
    };

I'll move this to contact ready

ksy36 commented 5 years ago

Contacted via mailing list

softvision-oana-arbuzov commented 4 years ago

The issue is no longer reproducible, sign in successfully performed and "Tracked prices" page is displayed. image

Tested with: Browser / Version: Firefox Nightly 68.2a1 (2019-10-16) Operating System: Huawei MediaPad T5 (Android 8.0.0) - 1920 x 1200 pixels, 16:10 ratio (~224 ppi density)

lock[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.