webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
749 stars 68 forks source link

mackie100projects.altervista.org - Add blocker warning pops up displayed even if with clean profile #52811

Closed webcompat-bot closed 3 years ago

webcompat-bot commented 4 years ago

URL: https://mackie100projects.altervista.org/download-clover-configurator/

Browser / Version: Firefox 76.0 Operating System: Mac OS X 10.14 Tested Another Browser: Yes Other

Problem type: Site is not usable Description: Page not loading correctly Steps to Reproduce: add blocker warning pops up but no adblocker in use

View the screenshotScreenshot
Browser Configuration
  • gfx.webrender.all: false
  • gfx.webrender.blob-images: true
  • gfx.webrender.enabled: false
  • image.mem.shared: true
  • buildID: 20200424000239
  • channel: aurora
  • hasTouchScreen: false
  • mixed active content blocked: false
  • mixed passive content blocked: false
  • tracking content blocked: false

View console log messages

From webcompat.com with ❤️

softvision-oana-arbuzov commented 4 years ago

Thanks for the report, but I'm not able to reproduce the issue. The message is displayed even with a clean profile and with TP disabled. image

Tested with: Browser / Version: Firefox Nightly 78.0a1 (2020-05-11) Operating System: Windows 10 Pro

Moving to Needsdiagnosis for further investigation.

karlcow commented 4 years ago

This is done here https://mackie100projects.altervista.org/wp-content/uploads/gjRMkWzIfJqm/bZIIUNNYjjzH.js?ver=2.2.3

They are testing the size of this image

<div id="adsense" class="an-sponsored" style="position:absolute; z-index:-1; height:1px; width:1px; visibility: hidden; top: -1px; left: 0;"><img loading="lazy" class="an-advert-banner" alt="sponsored" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"></div>
            if ($('#adsense.an-sponsored').length > 0) {
                if ($('#adsense.an-sponsored .an-advert-banner').outerHeight() === 0) {
                    $an_state = true;
                    $('#adsense.an-sponsored').remove();
                }
            }

and $('#adsense.an-sponsored .an-advert-banner').outerHeight() returns 0.

I wonder if the lazy loading is the source of the issue. The image has not been loaded yet so it's size is 0. The data by itself in a new window returns a 1x1 image.

This is happening even with tracking protection switched off.

@emilio what do you think here we should do here? does lazy-loading applies to data: resources too? If yes I will open a bugzilla bug for it.

emilio commented 4 years ago

lazy-loading applies to data: uris, but right now it doesn't in chrome. This is a chrome bug.

karlcow commented 4 years ago

Thanks.

Ah interesting. So this breaks in Firefox because Chrome can't deal at all with the data: uri. Very interesting consequence.

The chromium bug https://bugs.chromium.org/p/chromium/issues/detail?id=1047909

Let's switch to needscontact.

karlcow commented 4 years ago

They are on GitHub so they can probably fix this bug which affects firefox users and will affect chrome users, once chrome team is fixing their own bug. @mackie100

karlcow commented 4 years ago

@btwise seems to be another participant of the project who would be able to fix the bug.

softvision-oana-arbuzov commented 3 years ago

The issue seems to be fixed, I'm not longer prompted with the Ad-blocker popup. image

Tested with: Browser / Version: Firefox Nightly 91.0a1 (2021-06-03), Chrome 91.0.4472.77 Operating System: Mac OS Big Sur v.11.13.1, Windows 10 Pro

@emilio can you still reproduce it?

emilio commented 3 years ago

Yeah, wfm now.