search

webcomponents-cg / community-protocols

Cross-component coordination protocols
179 stars 12 forks source link

[context] Rename `multiple` to `subscribe` #40

Closed justinfagnani closed 1 year ago

justinfagnani commented 1 year ago

Fixes #24 and #21

Clarifies the language around when a provider should keep a reference to a request callback. Some minor related example cleanup too.

justinfagnani commented 1 year ago

cc @benjamind

benjamind commented 1 year ago

Yes looks good to me, thanks for pulling this up from the lit/context implementation @justinfagnani!

justinfagnani commented 1 year ago

Thanks y'all. I'm going to go with the written LGTM here and merge!