webdevops / TYPO3-metaseo

TYPO3 MetaSEO Extension
https://typo3.org/extensions/repository/view/metaseo
GNU General Public License v3.0
38 stars 24 forks source link

8TLS: Awesome Font: Icon not working any more #415

Closed thomaszbz closed 7 years ago

thomaszbz commented 7 years ago

MetaSEO version: 3.0.0-dev TYPO3 version: 8.7.0 PHP version: 7.0.16

Lately introduced (#359 / 2.0.4) icon using Awesome font is broken already in 8 LTS.

Here's how it looks like in 3.0.0-dev / 8 LTS with patch f73b32744e56fbf432ecf2cf21dc0ba11e9b6b79 applied:

auswahl_206

That's pretty much the same as in metaseo 2.0.3, together with TYPO3 7.6.

Here's how it looked like in 2.0.4/7.6 LTS with patch f73b32744e56fbf432ecf2cf21dc0ba11e9b6b79 applied:

jcgt5kpsjt

@simonschaufi If you are willing to patch this again, please check out branch feature/8lts and a TYPO3 CMS 8.7.x of your choice.

Related: #359, #408, #407

simonschaufi commented 7 years ago

I figured out the problem. It's about iconIdentifier and icon. In v7 iconIdentifier is stronger than icon, in v8 it was turned around. Therefor I need to "unset" the icon.

These seam to be the breaking commits: https://github.com/TYPO3/TYPO3.CMS/commit/241497a2ab5e34501ead41106e021de0145b8332 https://github.com/TYPO3/TYPO3.CMS/commit/562b7c1d19d29579f86082596c6493207b2d4da8

thomaszbz commented 7 years ago

Doing so won't break 7 LTS, now that branch feature/8lts aka 3.0.0-dev is for 8 LTS only.

thomaszbz commented 7 years ago

Thanks!