search

webdriverio-boneyard / wdio-sauce-service

WebdriverIO v4 service for better Sauce Labs integration
http://webdriver.io
MIT License
18 stars 21 forks source link

Ability to detect step failure for cucumber v3 and v4 #55

Closed Kignuf closed 6 years ago

Kignuf commented 6 years ago

Hello,

The cucumber API has changed again on v3, thus sauce plugin is currently enable to detect failures when using wdio-cucumber-framework v2.x (which upgrades from cucumber v2 to v3-v4). This fixes that problem by adding the proper failure condition.

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Kignuf commented 6 years ago

Hello Christian, thanks for the quick reply. Here is the v5 PR

christian-bromann commented 6 years ago

Thanks!

Planning on a v4 release tomorrow.

Kignuf commented 6 years ago

Great, thanks a lot Christian !