search

webdriverio / expect-webdriverio

WebdriverIO Assertion Library
https://webdriver.io
MIT License
76 stars 52 forks source link

Make sure toBeElementsArrayOfSize doesn't delete passed in array #1706

Closed brickfungus closed 3 weeks ago

brickfungus commented 3 weeks ago

Fixes https://github.com/webdriverio/expect-webdriverio/issues/1679

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann commented 3 weeks ago

It seems like the updates to the Eslint dependencies has caused an issue in the pipeline.

brickfungus commented 3 weeks ago

Okay I'll take a look at that. I did try structuredClone at one point

brickfungus commented 3 weeks ago

@christian-bromann why is it testing on node v16 when the package.json file has "engines": { "node": ">=18 || >=20 || >=22" }

christian-bromann commented 3 weeks ago

why is it testing on node v16 when the package.json file has "engines": { "node": ">=18 || >=20 || >=22" }

I recognised that the other day, we have to bump the Node.js versions here.

brickfungus commented 3 weeks ago

I changed the workflow file to drop 16 and add 22. Didn't think wdio supported node 16 anymore, anyways, but if you want to do something different, let me know

wdio-bot commented 3 weeks ago

Hey brickfungus 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day, The WebdriverIO Team 🤖