LightweightCoreset should allow for other distance metrics - Githubissues

webis-de / small-text

Active Learning for Text Classification in Python

https://small-text.readthedocs.io/

MIT License

547 stars 60 forks source link

LightweightCoreset should allow for other distance metrics #43

Closed chschroeder closed 7 months ago

chschroeder commented 1 year ago

Feature description

To make lightweight_coreset() more similar to greedy_coreset(), it should be able to similarly change the distance metric in lightweight_coreset() via an additional keyword argument distance_metric.

Motivation

Those functions solve a similar problem, they should be kept as similar as possible. Also, it improves the functionality of lightweight_coreset().

Addition comments

A PR should start on the dev branch (as 2.0.0 will be next).
Code that is shared between those two functions should be extracted whereever possible.
lightweight_coreset() needs an additional unittest to verify the result.