Make prelu() bidirectionally broadcast, improve broadcast wording

webmachinelearning / webnn

🧠 Web Neural Network API

https://www.w3.org/TR/webnn/

Other

397 stars 48 forks source link

Make prelu() bidirectionally broadcast, improve broadcast wording #743

Closed inexorabletash closed 4 months ago

inexorabletash commented 4 months ago

Just say "broadcast" not "broadcasted"; Merriam-Webster says the former is preferable.
Make prelu() bidirectionally broadcast instead of unidirectionally broadcast, as it's not an obvious unidirectional case.
Make preamble more consistent across operations in calling out broadcasting and stating the requirements for input tensors.
Shorten algorithm link, e.g. from "...broadasting the shapes A's shape and B's shape" to just "...broadcasting A's shape and B's shape"

Resolves #590

inexorabletash commented 4 months ago

It seemed like this was the only actionable work for #590

I was pondering adding informative notes to the algorithms e.g. explaining when/where bidirectional/unidirectional broadcasting should be used, but inspiration didn't strike. Suggestions welcome!

inexorabletash commented 4 months ago

@a-sully and @fdwr can you take a look?

inexorabletash commented 4 months ago

... and if we want more text about broadcasting, I sketched something out in https://github.com/webmachinelearning/webnn/issues/378#issuecomment-2253655000 - I could pull that into this PR if desired.

a-sully commented 4 months ago

LGTM 👍 I especially like s/broadasting the shapes/broadcasting