File Manager: Future improvements

[iliajie]

To make new File Manager shinier we need to add:

1. Manage symbolic links - added on 19.20-beta5 (October 03, 2018) https://github.com/authentic-theme/authentic-theme/issues/629#issuecomment-426615864
2. Extend search with ability to specify user and group, file type (file, directory, symlink) - added on 19.70-beta2 (December 24, 2020) https://github.com/authentic-theme/authentic-theme/commit/4ee8d653134c1c66e87d16bbf1490fcb472da292

To make it more powerful and comfortable to use, lets add some extra functionality:

1. Ability to diff two files #612
2. Movable and resizeable editor windows - added on 18.49 (May 18, 2017)
3. Image viewer with simple editor functionality; audio and video player - added on 19.32 (April 28, 2019)
4. Viewing archives content
5. Ability to download directory - added on 19.14 (April 26, 2018) https://github.com/qooob/authentic-theme/commit/9f114ace9d262299e02cb877da22e8e9cb588562
6. Selecting files/directories using wildcard
7. Calculate and verify checksum of files - added
8. Split and combine files

9. Exclude from search given folders - _added on 19.38 (July 20, 2019)

   10. Multi-rename tool

   11. Add multiple uploads - added

   12. Add an option to automatically extract uploaded file(s) - added

   13. Edit/reorder bookmarks (not just delete/add)

   14. In File Manager, when extracting an archive, all files and folders gets root-root. In Java File Manager setting you can select the default user as "same as the directory". Or if you want to change you can do it in the upload dialog. And you also can select "Upload, Extract and Delete file" in one action. #52020 - added

15. Tree-view - added on 19.10-beta1 (March 18, 2018) https://github.com/qooob/authentic-theme/issues/1066

16. QuillJS - HTML, rich text editor - added on 19.10-beta4 (February 28, 2018) https://github.com/qooob/authentic-theme/issues/1031

17. Integrate Disk Usage module

18. Add text conversion for text editor - added

19. Add ability to reset column sorting https://github.com/qooob/authentic-theme/issues/1088 - _added on 19.38 (July 20, 2019)

20. Abort current call, when clicking the other link - added on 19.13-beta2 (April 17, 2018) https://github.com/qooob/authentic-theme/commit/3cdc3ec218384381c9107eed15db4781c21b229c

21. Add management for password protected archives https://github.com/webmin/webmin/issues/702#issuecomment-378905759 - added on 19.32 (April 28, 2019)

22. Manage file-size calculations on client-side for already calculated directories https://github.com/qooob/authentic-theme/issues/1136

23. Add ACLs control https://github.com/authentic-theme/authentic-theme/issues/1229#issuecomment-437895185

24. Upload directories -- added

Anything else you miss/wish? Please comment below.

[iliajie]

Feature Movable and resizeable editor windows has been added to 18.49 release.

Added dropdown menu with yummy stuff for the editor.

1. Align Panels Vertically (when the menu is opened hold Alt to see the magic happening. Besides holding Shift will reverse panels arrangement)
2. Toggle Soft Wrap
3. Refresh Content
4. Help (moved away from the top)

[iliajie]

https://github.com/qooob/authentic-theme/commit/f086f2ad9b8bfb2e567c2706d5ed7bd313888425

[iliajie]

Added support for creating symbolic links in File Manager.

[xulinbao]

Google Chrome can't load file manager. demo：https://www.scall.xyz/file.mp4 File management is always loading.

The Firefox browser loads the file manager normally.

Sometimes it is normal, very confused.

[iliajie]

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

[iliajie]

Did it solve your issue?

[sz00gun]

If possible could you please fix better view on mobiles. Either menu more narrow or higher z-index for menu.

That's not bad:

[jonathanisodme]

Not sure if this is the right place, but I would like an option to edit file manager settings on filemin. It would be useful to be able to enable/disable the encrypt feature and some other features for the virtual server owners.

[iliajie]

@leijonathan It's better to open separate issue.

I don't understand what you mean. What do you mean enable/disable encrypt feature?

[qwrty-ftw]

Hello @rostovtsev

Do you have any ETA about the point number 23 ?

Thank you very much.

[iliajie]

I am closing 19.3x branch soon with small bug fixes, and starting 19.4x. There I am adding new mail compose feature, and most likely, new read mail feature and other features, among which could be ACLs for File Manager.

Do you find this feature useful and worth time investments? I personally never had a need to deal with it. What are your real-life examples, when you would need it (just curious). I suppose it could go under existing Permissions modal, in case getfacl/setfacl commands are available and kernel supports it. Does device (fs) needs special acl flag upon mounting or it would just work?

[qwrty-ftw]

To be honest, I do not use ACL each day, but when I am using it, I prefer a graphical management, it's more clear, but i can deal with CLI. I use ACL to manage user acces to specific files/folder. For example many user/group can have RW acces to specific folder but not the other one.

But if it's not a hard work I would love see this improvement to your file manager :D

If i understand your last sentence, I think it's specific to each fs. For example, like ZFS, I should specified the correct flag to use ACL. (zfs set acltype=posixacl )

[iliajie]

@ochbob Okay, I'll look into it for 19.40 release. :smiley_cat:

[snickers2k]

+1 for ACL

two other things would be

• small view/dropdown to monitor ongoing/historic operations like file-transfers etc.
• split/dual-view

[xulinbao]

Hi,

May be it's sone fancy cache issue? Hit Ctrl+Alt(Options)+Shift+Meta(Control)+R.

Is Firefox and Chrome on the same machine? Is the accessed server the same?

Sorry, I just noticed the news, it is estimated that it is my local country network problem.

[iliajie]

@ilinbxu Which country in particular is that?

[xulinbao]

In China, after I opened the VPN, it was normal.

[iliajie]

@ilinbxu Sorry to hear that, and I'm glad you're free from censorship now.

[zuhairmahd]

@rostovtsev it would be great if keyboard navigation support could be added to the file manager tree -- this would be very helpful for accessibility users (keyboard only users and screen reader users) who do not use a mouse. Currently, the tree can receive focus, but you are unable to expand and collapse the tree using keystrokes, and also cannot navigate the tree. Expected behavior is:

1. Up/down arrow: vertically navigate the tree
2. Left arrow: collapse the node your highlight is in
3. Expand the node your highlight is on

Note by the way that the screen reader can properly announce the name and collapse/expand status of the node receiving focus.

Please let me know if you'd rather I open a seperate issue and link it to this one -- would be glad to do that.

[iliajie]

Thank you for your suggestion. I will try to make it possible on the next release.

[iliajie]

Zuhair,

I have added this for you promptly. Try installing latest development version of the theme (19.40-alpha2) to give it a try. :smiley_cat:

[zuhairmahd]

@rostovtsev that was quick! It is working as expected. I expected there to be a lag when moving in the tree while the other pain refreshes but it is actually pretty quick!

Thanks!

[solaceten]

@rostovtsev

1) Is there a reason why double clicking on a file (e.g. public_html/index.html) does not open it or enable a preview / view of it ?

Same for right click on file - why do we not have "view" or "preview" option? Only edit ....

2) Should folders on left main tree be yellow (mine are white but yellow on the right side pane)

3) Could it be possible to add drag / drop from right pane to the left main tree?

[iliajie]

Is there a reason why double clicking on a file (e.g. public_html/index.html) does not open it or enable a preview / view of it ?

It sounds like possible improvement. I could do it, I think.

Same for right click on file - why do we not have "view" or "preview" option? Only edit

Nobody ever asked for it, so I have never done it. I think it's worth adding it, you're right.

Could it be possible to add drag / drop from right pane to the left main tree?

Umm, I guess it's possible. It will require some work though. Although, isn't it easier, and safer using hotkeys, as Ctrl-C/Ctrl-V (Cmd-C/Cmd-V on Mac) to copy/paste?

---

Edited:

Should folders on left main tree be yellow (mine are white but yellow on the right side pane)

I don't really know. May be. It would make it more consistent, I guess. I will think what I can do to improve icons for mime types and folders. It would require at least one more new yellow icon for opened folder.

[iliajie]

I think the reason why I didn't make yellow icon on the tree, is that it would make the tree look clogged.

[iliajie]

If possible could you please fix better view on mobiles. Either menu more narrow or higher z-index for menu.

Yes, it's better to use flexbox for it. Latest commit adds it. Have a look.

The more should be done in terms of File Manager controls itself.

[iliajie]

Okay, it's better to use flexbox for the whole header. I dropped old table layout and switched to native Bootstrap rows and columns.

Example:

[campones]

One thing I'd like is when you hit ctrl+F to search, to be able to search the next code/word using the arrow, or by hitting a search button several times. I have seen the scroll bar with the search result, it's nicely done

[iliajie]

One thing I'd like is when you hit ctrl+F to search, to be able to search the next code/word using the arrow, or by hitting a search button several times.

You can already do it by hitting F3 to search forward and Shift+F3 to search back up. It's quite standard, even regular browsers support it nowadays.

I have seen the scroll bar with the search result, it's nicely done

Thanks. :smiley:

[campones]

Works great indeed, thanks!

[campones]

the f3 remembers me the search in the windows registry :)

[campones]

One cool thing would be when you create a file, you have the filename, as it is now, and the editor block immediately below . instead to create and name the file, then click again on edit it

[iliajie]

You mean the newly created object (file or directory) would be auto-focused with the cursor?

[campones]

[campones]

of course with your wonderful editor's formatting, and lines number (really missing in the old java file manager)

[iliajie]

It's possible, along with adding:

1. Focus after create new file/folder/rename on the active row
2. Focus nearby element when deleting
3. Opening newly created file automatically.

Working on it. It will all be the part of 19.43 release super soon.

[iliajie]

The latest commit adds it and few more improvements. Try it with the latest dev version.

Add ability to focus rows in post-actions in File Manager

1. After file/directory was deleted, the focus will go either to next or previous row
2. After file/directory was renamed/created the focus will be placed on this row
3. If file (not directory) was created, the editor will be opened automatically for it

Fixed:

1. Calculation of file size for files containing HTML
2. Fix (just a minutes ago) pagination calculations on post-actions

[campones]

I couldn't try last time I checked because I need a dev version of webmin 1.9.32 I believe.

[iliajie]

Well, there is a small mismatch in filesize labels but as far as I remember, it will not fail and will work just fine. You could force install it. You can always downgrade the theme to the needed version, using theme update script from its directory.

[campones]

ok , I ll try , it's a local server anyway. thank you

[campones]

I saw what you did, it's slightly different of what I thought, you create the file and auto open the created file to insert the code. fine, it's a way of doing it.

since I forced the update, I have a weird problem, when I m deep down on the tree of file, if I right click a file it scrolls up alone to the top

[iliajie]

Thanks for the feedback.

I'll take a look tomorrow. It's super late right now.

[iliajie]

I have to do release now (19.43). The issue you are talking about will be addressed in 19.43-1, just few days later.

[campones]

ok

2 notes I have:

I noticed the nice homepage stats, it looks great but it uses quite some cpu

also it could be nice to have either a word wrap in the editor, or even better, to be able to scroll horizontally with the mouse (but that would conflict with vertical scrolling if necessary so..)

[iliajie]

There is word-wrap already, just hit Ctrl+Alt+W to toggle it or use top right drop-down. By the way, starting from version 19.43 the word-wrap option will be automatically remembered.

About CPU usage, how much resources does it use? How did you get the data?

[campones]

oh I see the wrap menu item indeed, very nice, that's a game changer compared to the java editor..

can hit until 20% time to time

[iliajie]

Thanks.

You can disable Real-time stats in theme configuration, to decrease the load.

[campones]

yes, I did, did also install webmin 32 along with a reinstall of the theme 32 and no more issue with the right click on file

[iliajie]

You're right, it didn't work. I at first made this option just to be hostname based and later, hostname/logged in user based and there was a small bug.

Fixed now. Try again please. :)

[iliajie]

You're right, it didn't work. I at first made this option just to be hostname based and later, hostname/logged in user based and there was a small bug.

Fixed now. Try again please. :)

Wrong thread, sorry!