webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Fix minor bugs and code refactoring #47

Closed ssuminahn closed 3 years ago

ssuminahn commented 3 years ago

:Release Notes: Fix minor bugs and code refactoring

:Detailed Notes:

:Testing Performed:

  1. Pass unit test on ose
  2. Pass eslint
  3. Check below commands and results 3-1. ares-config -p ose

    check git status and no diff files/config/config.json 3-2. Check each operation of ares-install/launch/device

:Issues Addressed: [WRN-1725] Fix minor bugs and code refactoring of CLI

YoungeunKim commented 3 years ago

@ssuminahn , Could you update npm-shrinkwrap.json? The reason is that "ora" is added package.json in "add spinner" commit.

YoungeunKim commented 3 years ago

@ssuminahn < All unit test passed? When I ran unit test, it failed because "spinner" importing has been removed in some files. Please check and verify it again.

Code :-1: Verified :-1: