search

webosose / ares-cli

ares-cli is a command-line interface(CLI) for webOS
Apache License 2.0
38 stars 17 forks source link

Update deprecated Buffer on node v14.15.1 #5

Closed ssuminahn closed 3 years ago

ssuminahn commented 3 years ago

:Release Notes: Update deprecated Buffer on node v14.15.1

:Detailed Notes: Buffer() is deprecated on node v14.15.1, so the API fixed to instead another APIs

:Testing Performed:

  1. Before CLI test, change settings
    • Upgrade node version to v14.15.1
    • Remove node_modules
    • Re-install npm as 'npm install'
  2. Check below commands to make sure it works without warning messages
    • node ares-package.js webapp
    • node ares-install.js com.domain.app_1.0.0_all.ipk
    • node ares-package.js -s ../spec/tempFiles/sign/signPriv.key -crt ../spec/tempFiles/sign/sign.crt webapp
  3. Pass unit test on auto target and ose emulator
  4. Pass eslint

:Issues Addressed: [PLAT-129806] Update deprecated Buffer on node v14.15.1

ssuminahn commented 3 years ago

code :+1: verify :+1:

YoungeunKim commented 3 years ago

Code :-1: @ssuminahn, It seems that your Buffer function changes are good. https://stackoverflow.com/questions/52165333/deprecationwarning-buffer-is-deprecated-due-to-security-and-usability-issues/52165509

Please clean-up logs.