webpack-contrib / babel-minify-webpack-plugin

[DEPRECATED] Babel Minify Webpack Plugin

MIT License

491 stars 44 forks source link

fix: import `babel` as an ES2015 Module #58

Closed boopathi closed 7 years ago

boopathi commented 7 years ago

Previously, this plugin had require statements. So

const babel = require("babel-core")

worked. But because we are using ES6 modules and babel-core doesn't have any default export, we cannot do that anylonger.

Other changes:

Refactor tests to use async functions
Add test to ensure the minification works
Add overrides tests

codecov-io commented 7 years ago

Codecov Report

Merging #58 into master will increase coverage by 18%. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #58    +/-   ##
=====================================
+ Coverage      66%   84%   +18%     
=====================================
  Files           2     2            
  Lines          50    50            
  Branches       17    17            
=====================================
+ Hits           33    42     +9     
+ Misses         15     8     -7     
+ Partials        2     0     -2

Impacted Files	Coverage Δ
src/index.js	`85.71% <100%> (+18.36%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d55caf...ef2d08f. Read the comment docs.

codecov-io commented 7 years ago

Codecov Report

Merging #58 into master will increase coverage by 18%. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #58    +/-   ##
=====================================
+ Coverage      66%   84%   +18%     
=====================================
  Files           2     2            
  Lines          50    50            
  Branches       17    17            
=====================================
+ Hits           33    42     +9     
+ Misses         15     8     -7     
+ Partials        2     0     -2

Impacted Files	Coverage Δ
src/index.js	`85.71% <100%> (+18.36%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d55caf...4528b8c. Read the comment docs.

boopathi commented 7 years ago

continuous-integration/appveyor/branch - How to run this check? It's in pending status and there are no details link where I can see/debug what's happening.

joshwiens commented 7 years ago

@boopathi - For reference, I had the wrong appveyor check selected as required ( should have been PR not branch ).