search

webpack-contrib / sass-loader

Compiles Sass to CSS
MIT License
3.91k stars 431 forks source link

fix: generate correct sourceMaps when custom importer is used #1228

Closed DaiQiangReal closed 3 months ago

DaiQiangReal commented 3 months ago

This PR contains a:

Motivation / Use-Case

Generate correct sourceMaps when custom importer is used.

https://github.com/sass/sass/issues/3300

https://github.com/webpack-contrib/sass-loader/issues/1217

Breaking Changes

Additional Info

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.18%. Comparing base (31789cc) to head (87d7744). Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1228 +/- ## ========================================== - Coverage 94.44% 94.18% -0.26% ========================================== Files 3 3 Lines 360 413 +53 Branches 132 156 +24 ========================================== + Hits 340 389 +49 - Misses 18 22 +4 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DaiQiangReal commented 3 months ago

Changed Commit message for type lint.

alexander-akait commented 3 months ago

@DaiQiangReal Added test, let's wait CI

alexander-akait commented 3 months ago

Ignore commit message I will fix it when will merge

alexander-akait commented 3 months ago

Thank you