search

webpack-contrib / worker-loader

A webpack loader that registers a script as a Web Worker
MIT License
1.46k stars 273 forks source link

doc: be clear that this is webpack 4 specific #322

Closed gthb closed 3 years ago

gthb commented 3 years ago

This PR contains a:

Motivation / Use-Case

I spent a bunch of time troubleshooting Cannot read property 'version' of undefined in my setup before coming across this comment in Next.js's worker-loader example. This is to save others that waste of time. :)

Breaking Changes

No breaking changes, just a small note in the README.

Additional Info

N/A

alexander-akait commented 3 years ago

Here only one limitation - inline, webpack 5 doesn't support inline, but for modern browers I don't think this feature really required

codecov[bot] commented 3 years ago

Codecov Report

Merging #322 (040d9d9) into master (80b3fdf) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   75.83%   75.83%           
=======================================
  Files           6        6           
  Lines         149      149           
  Branches       52       52           
=======================================
  Hits          113      113           
  Misses         30       30           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80b3fdf...040d9d9. Read the comment docs.

alexander-akait commented 3 years ago

Can you accept CLA?

gthb commented 3 years ago

Can you accept CLA?

Done.