The current impl<T: AsTcpStream> AsTcpStream for Box<T> requires T: Sized. This means that anyone using ClientBuilder::connect will not be able to call the various shutdown methods, since the returned type is Box<dyn NetworkStream + Send>. After this change, the modified impl will apply to Box<dyn NetworkStream + Send>, which was presumably always intended.
vi
commented
5 years ago
The current
impl<T: AsTcpStream> AsTcpStream for Box<T>requiresT: Sized. This means that anyone usingClientBuilder::connectwill not be able to call the variousshutdownmethods, since the returned type isBox<dyn NetworkStream + Send>. After this change, the modified impl will apply toBox<dyn NetworkStream + Send>, which was presumably always intended.