Closed dpcpnry closed 2 years ago
Code and steps to create the Stardict dictionary data above:
https://gist.github.com/dpcpnry/df8b0722b0274aa999d01328c893fe38
I've spent some time discovering the source of this problem. I don't have a fix yet but I believe these definitions are getting dropped in the process of filtering out non-Webster definitions. Even though these definitions have the correct source, they are getting dropped. You can confirm this by running with ONLYWEBSTER = false
.
The filtering is very fragile, so it’s probably every-so-slightly different for these lines vs the ones that are kept.
@jeffbyrnes @dpcpnry I've opened a PR that should address this if you'd like to test it out.
I saw, thanks! I’m moving today, so will probably get a chance to review this weekend. On Jan 5, 2022, 10:32 AM -0500, Nick Wynja @.***>, wrote:
@jeffbyrnes @dpcpnry I've opened a PR that should address this if you'd like to test it out. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
Fixed via 3375fe69
Edit: After many hours of of trial and error on my phone with Termux (I don't have a computer with me these days), I managed to convert this new format to Stardict. See the next comment.
During the process, I noted the following issue.
It seems that some lines in definitions get lost in the output files (for example: in template/dict.xml file).
For example, with the word "happy", in srcFiles/CIDE.H, its original entry is:
It is missing the following lines, given that they all have the same []:
See the attached picture to compared with an old format Stardict dictionary data, from Jsomers link