webstudio-is / webstudio

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
https://webstudio.is
GNU Affero General Public License v3.0
5.1k stars 597 forks source link

Section links on dynamic pages use the raw parameter, not the value #4144

Open johnsicili opened 1 month ago

johnsicili commented 1 month ago

When linking to a section on a dynamic page, the HTML is showing the parameter such as /:slug#mysection instead of the current value of the parameter.

Screenshot 2024-09-20 at 7 03 21 AM
  1. Add dynamic page
  2. Add a box
  3. Give box an ID
  4. Add a link and select the current page and the section
  5. Inspect HTML and see the parameter, not its value

Related: https://github.com/webstudio-is/webstudio/issues/3560

kof commented 1 month ago

Another related issue is mentioned here https://github.com/webstudio-is/webstudio/issues/2646#issuecomment-2371387916

also link resolution to page with dynamic url containing variable does not work.. Link to page does not render correct link and keeps variable as text there

I am not sure if its the same or something else

istarkov commented 3 weeks ago

And what the solution? The page is dynamic and needs dynamic parts to be defined on the link.

image

We need to show Dynamic section or like on the form above and inject parameters into the url.

Or just disable linking dynamic pages using UI