webtorrent / parse-torrent

Parse a torrent identifier (magnet uri, .torrent file, info hash)
https://webtorrent.io
MIT License
441 stars 82 forks source link

BEP46 — Mutable Torrents #119

Closed robbert229 closed 1 year ago

robbert229 commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [X] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

This PR contains #58, but rebased off of master, and contains some tweaks to make it work since #58 is quite old.

Which issue (if any) does this pull request address?

N/A

Is there anything you'd like reviewers to focus on?

N/A

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

socket-security[bot] commented 2 years ago

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
ed25519-supercop@2.0.1 (added) binding.gyp package.json
ed25519-supercop@2.0.1 (added) install package.json
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
ed25519-supercop@2.0.1 (added) binding.gyp package.json
Pull request report summary
Issue Status
Install scripts ⚠️ 2 issues
Native code ⚠️ 1 issue
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore ed25519-supercop@2.0.1

Powered by socket.dev