search

webtorrent / webtorrent-cli

WebTorrent, the streaming torrent client. For the command line.
https://webtorrent.io
MIT License
1.18k stars 135 forks source link

Add peerflix-style interactive select mode #234

Closed alexose closed 2 years ago

alexose commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [X] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

Added a peerflix-style interactive select mode.

Which issue (if any) does this pull request address?

https://github.com/webtorrent/webtorrent-cli/issues/130

Is there anything you'd like reviewers to focus on?

Hopefully I got the formatting right!

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

alexose commented 2 years ago

Ping!

DiegoRBaquero commented 2 years ago

Can you add a video/gif of it working? Also, are there any scenarios were the await might throw an error? if that's the case, would be great to handle it

alexose commented 2 years ago

Here's a gif of it in action:

webtorrent

alexose commented 2 years ago

Per inquisitor's README.md, it can indeed throw errors if the terminal isn't capable of rendering the menu for some reason. The above commit should handle this case (and anything else that might result in an error).

welcome[bot] commented 2 years ago

🎉 Congrats on getting your first pull request landed!

webtorrent-bot commented 2 years ago

:tada: This PR is included in version 4.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: