search

webtorrent / webtorrent-cli

WebTorrent, the streaming torrent client. For the command line.
https://webtorrent.io
MIT License
1.18k stars 135 forks source link

fixes https://github.com/webtorrent/webtorrent-cli/issues/245 #246

Closed zackees closed 2 years ago

zackees commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

Webtorrent cli seeding currently shows the torrent infohash. However, seeders need to know the magnetURI, which also contains the hash. Therefore this PR changes the printing of infohash to the magnetURI.

Which issue (if any) does this pull request address?

https://github.com/webtorrent/webtorrent-cli/issues/245

Is there anything you'd like reviewers to focus on?

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

zackees commented 2 years ago

@DiegoRBaquero @watson @mvayngrib @feross @Flet @alxhotel

zackees commented 2 years ago

Ping on this change.

This is super important to use the cli since magnetURI's are useful, and the current status quo of printing just the hash is insufficient.

pad01g commented 1 year ago

+1 for this change. maybe add another field for magnet uri to be backward compatible.