Closed bleds22e closed 7 years ago
In trnL_data_prep.R, you added a setwd hard path. I a) don't think this is actually needed since you have a RStudio project and b) will keep me from being able to run the code as is. If all of our datafiles are being kept in the repo (or in a folder with a similar relative position to the repo folder) we can just use relative paths. Is there a reason that wasn't working for you?
I asked Ethan about making changes to a PR in a situation where later PRs depend on this PR. He turned green, said a lot of frightening words, used the phrase "if you do X, it might be ok". I finally got him to say that if the changes are minor and we think we can clean them up after all the PRs are merged that this is the "safest way" to deal with that. So I am going to go ahead and merge this PR and I will turn my previous comment into an issue so we can deal with that later.