wehs7661 / ensemble_md

A python package for performing GROMACS simulation ensembles
MIT License
13 stars 4 forks source link

Further refine the unit tests of `ensemble_md` #49

Closed wehs7661 closed 7 months ago

wehs7661 commented 7 months ago

Now the code coverage has been enhanced to 96%. However, we want to further refine the tests by accomplishing the following tasks, as listed in #41.


Update: We have deferred the following task and noted it Issue #50

Re-examine previously written tests to see if there are better ways to test the functions. Presumably a lot of tests could be made more rigorous/meaningful using unittest.mock. test_analyze_traj.py should be free from this since most of its tests have just been written recently.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (27320da) to head (5175648). Report is 21 commits behind head on master.

:exclamation: Current head 5175648 differs from pull request most recent head 7faf9cf. Consider uploading reports for the commit 7faf9cf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #49 +/- ## ========================================== + Coverage 96.10% 98.38% +2.28% ========================================== Files 10 10 Lines 1950 1921 -29 ========================================== + Hits 1874 1890 +16 + Misses 76 31 -45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wehs7661 commented 7 months ago

The currently implemented unit tests could trigger 21 warnings when performed. 18 of them are either DeprecationWarning or MatplotlibDeprecation Warning, which are harmless for the short term. The other 3 are RuntimeWarning:

For more details please check the changes made here.