search

weirdNox / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
1.08k stars 101 forks source link

Position on both axis #96

Open tobiasBora opened 4 years ago

tobiasBora commented 4 years ago

Hello,

First, thanks a lot for this nice tool. However, I would like to know if it would be possible to add notes with coordinates in both directions (horizontal and vertical). Indeed, on some articles (two columns), the arrow points in the left margin even if the note concerns a text on the right column. And similarly, if you zoom on the pdf to have one column at screen, it will not move to the good position.

Thanks!

weirdNox commented 4 years ago

Hello! I've also run into this issue, but I've just ignored it until now as I believe pdf-tools itself doesn't support placement of the arrows in the x-axis, so even if we had that information, it couldn't be used. I'm pretty sure the last time I looked into it (it was a long time ago, so it could have changed) it didn't have an argument for that.

We would need that, maybe you could suggest them that feature!

Another thing to keep in mind is that we must have backward compatibility in the way the coordinates are stored, as we need to have it working with all notes that have been created until now (and some of them will only use 1 coordinate, like EPUBs). That wouldn't be too hard, I believe, but needs some consideration and testing :)

igoralmeida commented 4 years ago

Maybe @politza can chime in?

abvbv commented 4 years ago

Hi @weirdNox!

I'm reading a two-column paper right now and making a precise note (M-i) in the second column inserts it out of order, above some of the notes from the first column. I understand why it happens (there's only one axis), but is it possible to insert new precise notes at the end of the notes file?

P.S. Thank you so much for the tool!

tim-hilt commented 4 years ago

Looking at pdf-tools, the project doesn't seem to be very active at the moment!

auroranil commented 4 years ago

related #48 - would like to see this enhancement in org-noter as well

vedang commented 3 years ago

Hello All,

I'm considering taking up maintainership of pdf-tools and am currently going through all the issues and PRs on the project and applying fixes / patches to vedang/pdf-tools . I'm posting an update here to let you know that I've seen this issue and the related patch, I want to test + reproduce the problem and then take the next steps. I will do this by the next weekend and hope to unblock this issue then.

ryanakca commented 2 years ago

Hi @vedang ,

I will do this by the next weekend and hope to unblock this issue then.

Has there been any progress on this since February? It would be great to finally have #129 merged in.