weirdgyn / viastitching

ViaStitching action-plugin for KiCAD
MIT License
60 stars 5 forks source link

Undo last edit (CTRL + Z) doesn't remove vias added by this plugin #13

Closed EdgarBarranco closed 1 year ago

EdgarBarranco commented 2 years ago

Hi,

Thanks for sharing this plugin, I am new to kicad and on the other cad programs, this is very easily done, but I could not find a way to do the via stitching on a zone until I found this plugin.

At first I was trying this plugin out and luckily I saved the board before running it because I was not able to remove the 5000+ vias added to the board with undo. So I closed it and re-open it and was back to the clean board and corrected the density problem, but it would be a good feature if undo would actually undo the via stitching also. Maybe a feature request, a workaround maybe would be if all the new vias are selected so a delete would remove them?

Thanks again.

weirdgyn commented 2 years ago

hi Edgar,

this is a feature request: of course you are free to submit it, but it may take some time to implement... The Undo command relies on the KiCAD API's ability to expose the state of internal objects (pcbs, schematics etc.) when I started coding Viastiching there was no support for it and I have no idea if it currently is, so I couldn't provide that functionality (and consequently it might not even be possible to provide it now). Anyway, as you can see (or read in the readme), you can "delete" vias from the plugin dialog. This isn't really an "undo" feature, but it allows you to remove implanted vias from the plug-in itself, so it should be pretty straightforward to use (it works even if you've 'saved' the pcb).