search

wekan / ldap

LDAP support for Wekan code has been moved to https://github.com/wekan/wekan/tree/master/packages/wekan-ldap , issues to https://github.com/wekan/wekan/issues , and if PRs are needed please add them instead to https://github.com/wekan/wekan/pulls
https://github.com/wekan/wekan/tree/master/packages/wekan-ldap
MIT License
12 stars 10 forks source link

Why lower case "ldap-username-field"? #56

Open Daniel-H76 opened 5 years ago

Daniel-H76 commented 5 years ago

Wekan uses the "username" field for email salutation ("Dear username,") and subject line ("admin sent you an invitation") and we can use "ldap-username-field" to fill it with something usefull via LDAP authentication. As the field doesn't support spaces (will get replaced by dots) it makes most sense to use the "givenname" attribute in my opinion. Unfortunately it gets converted to lower case.

"Dear Daniel" would be a much nicer salutation than "Dear daniel". Any chance to preserve the case? Otherwise I'd recommend to use the "Full Name" within emails (this one preservce the case).

adelphi-company commented 5 years ago

and we can use "ldap-username-field" to fill it with something usefull via LDAP authentication. As the field doesn't support spaces (will get replaced by dots) it makes most sense to use the "givenname" attribute in my opinion.

It seems that it is NOT a good idea to fill the ldap-username-field by the givenName attribute : If two users are having the same username Wekan totally gets confused. Only one user is created but the profile information is mixed up (full name changes after login but e-mail doesnt).

Therefore I like to request a new case sentitive field for email salutation (e.g. ldap-salutation-field) and recommend to keep the ldap-username-field by something more unique, e.g. userprincipalname.