search

welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress
https://wptools.it/wordmove
MIT License
1.87k stars 165 forks source link

Update Visual Composer urlencoded urls #431

Closed zoltanseer closed 6 years ago

zoltanseer commented 6 years ago

Visual Composer stores the URL's as urlencoded strings. Unfortunately the search/replace won't find these urls. Is there a way to replace also the urlencoded WP url?

A not so optimal way would be to double search/replace: //old-url.com => //new-url.com and %3A%2F%2Fold-url.com => %3A%2F%2Fnew-url.com

alessandro-fazzi commented 6 years ago

Hello @zoltanseer ,

sorry if I'm going to be rude, but I like to be open and sincere. I think that most of the things Visual Compose does are crimes against the developer being. 🤔🤭🤫😱

Our effort is to be as standard compliant as possible, thus we've introduced the official search-replace command as our adapter - and we're going to set it as the default one in next releases. urlencodeing strings is not intended to be a storage strategy by any means, IMHO, and I think

  1. it should be a VC problem. I'm sure they know people around the globe are embracing a sane development flow with dev/staging/production scenario and the need to move things around.
  2. we - as developers, not just as Wordmove maintainers - should not be bad-practices-compliant

Please, consider I'm not upset with anyone here: I just have an opinionated approach to the work. And that I come in peace. And that I'm anyway open to the discussion.

Going to close this as a won't fix, but feel free to continue the thread.

zoltanseer commented 6 years ago

You are absolutely right about what the guys have done with Visual Composer. Unfortunately annoying requirements are also requirements.

It's ok that this function won't be included in the future, my post was more a question if it's possible with the current version.

Thanks for your answer.