Closed jennpb closed 1 year ago
To confirm: we were removing the URL on the Licence label and the credit, is that correct?
Yes, and that's because we've got the licence link in the humanReadableText so no need to duplicate it
Another question: I might misunderstand what is Credit and what is Attribution. Currently in this work, what I have for Credit is "Wellcome Collection".
// iiif-image locations have credit info.
// iiif-presentation locations don't have credit info., so we fall back to the data in the manifest
const credit = digitalLocation?.credit || iiifCredit;
In your example, that looks like it's "Attribution". What would the difference be and where should I place this information?
In the current Copy URL component there is a GA event tracking clicks:
trackGaEvent({
category: 'CopyURL',
action: 'copy url to clipboard',
label: id,
});
As I have to modify it/create a new component for copying regular copy, do we want to add tracking there as well?
cc @taceybadgerbrook
@jennpb @rcantin-w, references in the code to GA event category, action and label were used by UA and are now obsolete.
However, there is an event called, "copy_url," tracks when a user clicks this
This is triggered when CSS selector matches [data-gtm-trigger="copy_url"], [data-gtm-trigger="copy_url"] * .
I would love to be able to track when a user copies the credit information. If you let me know what the CSS selector is, I can do the tagging in GTM.
@taceybadgerbrook i've added a GTM trigger on the new button which CSS selector should match [data-gtm-trigger="copy_content"], [data-gtm-trigger="copy_content"] *
so you're all good to set it up on the GTM side!
After a conversation with Ashley, Jamie and Jenn where we determined that credit vs attribution was a bit more complicated to untangle than we'd like, we're putting this under a toggle for now so we can compare various works and images more easily.
Now in prod under a toggle, will keep the ticket open as we haven't made a decision yet.
We are unable to create an ideal credit line as intended.
attribution and usage
label includes the location-of-original
data rather than the attributable source; this means we get text that says "This material has been provided by The Royal College of Surgeons of England. The original may be consulted at The Royal College of Surgeons of England."Third-party material
Wellcome Collection material
When presenting a credit line, we should be able to reliably include:
In the future, it would be best if we could have granular data, ideally as part of the IIIF manifest, that includes:
If we're happy with this, I'll of course remove the section names.
Credit displays if there is a IIIF Presentation or IIIF Image credit field.
Yes, but if there's a credit, it should not be part of Source:
I would expect this example to be formatted as:
DNA analysis. Paul Griggs. Source: Wellcome Collection. Attribution 4.0 International (CC BY 4.0).
Should we now remove the "Licence" section above "Licence and re-use"?
Yes
@jennpb the discussed changes are in prod: https://wellcomecollection.org/works/a227dajt
For the record, this was implemented as:
{Title}. {Credit}. Source: Wellcome Collection. {Licence label}
AND when item is from a third party, a separate section for Provider which is taken from location-of-original
@rcantin-w This is fine to remove from toggle! 🛳
In prod, from behind the toggle
What?
Credit information on the works page is currently confusing and potentially misleading.
{Title}. {Credit}. {Licence label}. Source: {Attribution}.
- NOTE: not everything has an explicit {Credit}. Devs need to decide from where to grab this data.To illustrate:
On works page:
When copied:
Dependencies
Bug https://github.com/wellcomecollection/wellcomecollection.org/issues/10221
Why?
To ensure that all users have the most accurate information we can give, so they can provide credit appropriately
Background
Reworked licence and credit information https://docs.google.com/document/d/1haxvwYphd5dF3dplmTmyN7H5vn7ovJohbi0RHU6AmD0/edit?usp=sharing