search

wengkit1 / pe

0 stars 0 forks source link

Error message is inaccurate #3

Open wengkit1 opened 1 year ago

wengkit1 commented 1 year ago

Bug Title: Error message for editing name does not match the error

Description

When I try to edit a name field of a patient, the error indicates that the command is invalid. But the error message is unclear.

Steps to Reproduce

  1. Open the app
  2. Attempt to edit a name 'edit 6 n/a'
  3. Observe error message.

Expected behavior

The message should explain that editing of a name is disallowed due to previous issues mentioned. But instead it explains that the command format is invalid. when editing a field of patient seems pretty valid of a format to an average user.

Actual behavior

The message indicates invalid command format. Screenshot 2023-04-14 at 2.26.42 PM.png

Environment

Additional Information

soc-pe-bot commented 1 year ago

Team's Response

Hi, thanks for making a bug report. However, I refer you to the section in our user guide (screenshot of excerpt attached below for reference) which describes the expected command format for edit_patient where we clearly mention that a) editing names is not allowed b) specify the correct command format, which does not have n/NAME in it. The error message when you ran ep 6 n/John Doe is exactly correct (the command format is not valid) and even provides the correct command format. From your own screenshot, the error message says:

Parameters: INDEX (must be a positive integer) [p/PHONE] [e/EMAIL] [a/ADDRESS] [t/TAG]...

From this error message it should be clear to the user that the name field cannot be modified, even if they have not seen the relevant portion of the UG about this (attached below for reference).

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am not saying that the error is wrong, but I am saying that the user may be confused with the error as to why the command is invalid, i.e editing name is disallowed. And also it is not that the format itself is wrong, it is that one of the constraints was violated. I hope this was clear in the description. I don't really think that the error message is clear that editing name is disallowed, even though a user using the app for the first time might assume so. I do think it should be verylow instead, I apologise.