pkg-config: add <includedir>/libzrtcpp to CFLAGS

tmatth commented 10 years ago

Also remove broken lines that are not required.

tmatth commented 10 years ago

Fixes issue #16

Lekensteyn commented 9 years ago

LGTM.

wernerd commented 9 years ago

This fix will be in the next release.

Werner

Am 11.01.2015 um 14:59 schrieb Peter Wu:

LGTM.

— Reply to this email directly or view it on GitHub https://github.com/wernerd/ZRTPCPP/pull/17#issuecomment-69495330.

Werner Dittmann email: Werner.Dittmann@t-online.de cell: +49 173 44 37 659 PGP key: 82EF5E8B

keszybz commented 9 years ago

This patch does not seem right:

previous way to include files (#include <libzrtpcpp/xxx.h>) still works, but now one can also use #include . Some people will use one some the other.
more importantly, not all header files installed by libzrtpcpp are properly namespaced, and this might lead to collisions (for this to work they should all start with Zrtp prefix or something). For example there's common/osSpecifics.h which is too generic to put in the include path.

I think it would be much better to internally include all headers using #include "libzrtpcpp/xxx.h", and only allow users of this library to use #include <libzrtpcpp/xxx.h>, and not modify cflags.

wernerd / ZRTPCPP

pkg-config: add <includedir>/libzrtcpp to CFLAGS #17