wesnoth / wesnoth

An open source, turn-based strategy game with a high fantasy theme.
https://www.wesnoth.org/
GNU General Public License v2.0
5.49k stars 1.02k forks source link

EI: Baneblade Item's Weapon Has a Hidden "Always Use On Defence" Effect That Should be Included in its Description #8914

Open IskarJarak01 opened 4 months ago

IskarJarak01 commented 4 months ago

Describe the desired feature

In Eastern Invasion, the player can gain an item, the Baneblade, which gives a unit an extra melee weapon with the Beserk special.

Normally, a defending unit with a choice of weapons may decide not to use a weapon with Beserk if it has a high chance of being killed.

The Baneblade item has a hidden effect which forces the unit to always use its Beserk weapon on defence by setting the weight of other melee weapons to zero. This should be included in the weapon's description as a dummy effect or similar.

Other notes: There's a minor issue where if another item that gives a melee attack is equipped afterwards (only the Plague Staff item) the unit will still consider using that attack on defence. Attacks gained from advancements (Horseman -> Knight) are still affected by the Baneblade item and aren't used on defence.

Wedge009 commented 4 months ago

@Dalas121 Should be straightforward to add the relevant explanation, right?

Dalas121 commented 4 months ago

Yeah, adding an explanation should be simple. "The baneblade will always be used when defending."

Fixing the attack-order bugs will be trickier; thanks for noticing and bringing this up. Does anyone know of a way to solve this kind of thing?

If I really needed to I could try replacing defense_weight with an ability that disables non-baneblade melee weapons on defense, but that seems messy.