weweswap / contracts

smart contracts
MIT License
2 stars 4 forks source link

feat: Add UniswapV3ViaRouterETH contract #73

Closed bitcoinbrisbane closed 1 month ago

bitcoinbrisbane commented 1 month ago

feat: Add UniswapV3ViaRouterETH contract

feat: Add UniswapV3ViaRouterETH contract

feat: Add UniswapV3ViaRouterETH contract

chore: set to max on deploy

chore: refactor base contract

chore: refactor base contract

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request involve updates to multiple files, primarily enhancing the documentation in README.md with new command examples and contract addresses. Additionally, several new smart contracts are introduced, including BaseUniRouter, UniswapV3ViaRouterETH, and modifications to existing contracts like UniswapV3ViaRouter and MergeWithMarket. The changes also include updates to the IAMM interface, deployment scripts, and test files, reflecting a comprehensive enhancement of the project's functionality and documentation.

Changes

File Change Summary
README.md Added new command for WEWE category and updated contract addresses.
contracts/core/adaptors/BaseUniRouter.sol Introduced BaseUniRouter contract with fee management and token swap functions.
contracts/core/adaptors/UniswapV3ViaRouter.sol Modified UniswapV3ViaRouter to inherit from BaseUniRouter, updated fee management, and renamed methods.
contracts/core/adaptors/UniswapV3ViaRouterETH.sol Added UniswapV3ViaRouterETH contract with buy/sell functionality for ETH.
contracts/core/merge/MergeWithMarket.sol Added treasury variable and updated mergeAndSell logic.
contracts/interfaces/IAMM.sol Replaced swap with buy and sell methods, updated events.
ignition/deployments/chain-8453/artifacts/UniAdaptorModule#UniswapV3ViaRouterETH.dbg.json New debug JSON file added for UniswapV3ViaRouterETH.
ignition/deployments/chain-8453/artifacts/UniAdaptorModule#UniswapV3ViaRouterETH.json New artifact JSON file added for UniswapV3ViaRouterETH with ABI and metadata.
ignition/deployments/chain-8453/deployed_addresses.json Added entry for UniswapV3ViaRouterETH contract address.
ignition/deployments/chain-8453/journal.jsonl Updated deployment journal with new contract deployment details.
ignition/modules/MergeWithMarket.ts Introduced MergeModule for the MergeWithMarket contract.
ignition/modules/UniAdaptor.ts Updated contract reference from UniswapV3ViaRouter to UniswapV3ViaRouterETH.
package.json Added new deployment script for MergeWithMarket.
test/Uniswap.test.ts Enhanced test setup for WETH and added new test cases.
test/constants.ts Added new constant WETH_ADDRESS.

Possibly related PRs

Suggested labels

SC, eat-all-the-tokens

🐰 In the meadow, where bunnies play,
New contracts bloom, bright as the day.
With swaps and sales, we hop with glee,
Documentation shines, as clear as can be!
Let's gather 'round, our work is done,
In this code garden, we’ve had our fun! 🌼✨


📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between c3152cd8eb050ffb042b016a406192c71e3495ef and bb665aac82b198220346fba9b7c177f6a0ca8c1b.
📒 Files selected for processing (1) * contracts/core/adaptors/UniswapV3ViaRouterETH.sol (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * contracts/core/adaptors/UniswapV3ViaRouterETH.sol
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.