wharfkit / session

Create account-based sessions, perform transactions, and allow users to login using Antelope-based blockchains.
Other
9 stars 1 forks source link

The `PromptElement` data type cannot be unknown #57

Open aaroncox opened 1 year ago

aaroncox commented 1 year ago

https://github.com/wharfkit/session/blob/20d64d6410effda124265cd94fabf0da8a08e0c8/src/ui.ts#L19-L23

While writing documentation I noticed that data: unknown still exists in the code. This needs to be more well defined and create constraints for the various types of elements that can be used, otherwise the instances of the UserInterface (like the @wharfkit/web-renderer) can just accept whatever data they want. This data needs to be standardized so that every implementation of the UserInterface has to follow the same rules.

It was good that this was unknown during development, while we still defined how interactivity occurred, but now needs to change over.

Related slack thread: https://greymass.slack.com/archives/C045MUS6F0F/p1685569547180519