search

whikloj / BagItTools

A PHP BagIt library
MIT License
11 stars 5 forks source link

Fix oxum calculation #2

Closed henning-gerhardt closed 4 years ago

henning-gerhardt commented 4 years ago

A simple solution for correction #1

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage     75.27%   75.27%           
  Complexity      435      435           
=========================================
  Files             6        6           
  Lines          1197     1197           
=========================================
  Hits            901      901           
  Misses          296      296
Impacted Files Coverage Δ Complexity Δ
src/Bag.php 73.94% <100%> (ø) 267 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dfb2a6...ee18b36. Read the comment docs.

whikloj commented 4 years ago

Hey @henning-gerhardt.

Good catch and thanks for this. Would you be willing to write a test to capture this issue so I don't make this mistake again?

henning-gerhardt commented 4 years ago

I can try it. I would extend the ExtendedBagTest class for this, if this is correct place.

whikloj commented 4 years ago

Whatever works, I had a plan for the organization of tests but it kinda fell apart so I'm just putting tests where ever seems most appropriate.

whikloj commented 4 years ago

Thank you @henning-gerhardt, I'll tag a 1.2.1 version for packagist.