search

whikloj / BagItTools

A PHP BagIt library
MIT License
11 stars 5 forks source link

End support for PHP 5.6 & 7.1 #7

Closed whikloj closed 3 years ago

whikloj commented 4 years ago

My plan is that the next major release (2.0.0) of BagItTools will require PHP 7.2.

@henning-gerhardt, @mjordan, @elizoller does this change in requirements cause any concerns?

I know that islandora_bagger currently requires 7.1.3. If it is more desirable I can move to a PHP 7.1 requirement for the 2.0.0 version and PHP 7.2 for 3.0.0.

Just trying to see how many versions I need to maintain.

mjordan commented 4 years ago

I'll test Islandora Bagger with a 7.2 minimum requirement and let you know how it goes.

mjordan commented 4 years ago

@whikloj As of 978810f11620c0eead22876e338f87bba77fcacc Islandora Bagger requires "php": "^7.2".

henning-gerhardt commented 4 years ago

@whikloj : No problem to go with PHP 7.2 as Debian 10 is providing PHP 7.3.

whikloj commented 4 years ago

Perfect, thank you.

elizoller commented 4 years ago

No problem from my perspective either.

whikloj commented 3 years ago

Resolved with https://github.com/whikloj/BagItTools/commit/fdff8e354f9ee76846d0583d6b1294ad48b4ddce