search

whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
69 stars 32 forks source link

Replace ServiceAddress by libsignal_protocol::ServiceId #334

Closed gferon closed 3 weeks ago

gferon commented 1 month ago

I hid a bunch of mistakes in there just to check if @rubdos is paying attention (jk, I think it should be fine).

This definitely changes some things, like in some cases when preparing protos, you would get the prefixed service_id_string for PNI (which was the raw UUID before). I'm pretty sure it didn't use to work correctly.

Thank you for reading.

gferon commented 3 weeks ago

I think this is ready to 🚢

Regarding your suggestions to use recipent = %recipient.service_id_string(), I'm not sure I exactly get it, because this is the impl of tracing::Value for String: https://docs.rs/tracing-core/0.1.32/src/tracing_core/field.rs.html#632 which means we don't need to call the fmt::Display wrapper one.