search

whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
69 stars 32 forks source link

Possibly unintended synchronisation of ReceiptMessage #343

Open hrdl-github opened 3 weeks ago

hrdl-github commented 3 weeks ago

As described in https://github.com/whisperfish/presage/pull/290#issuecomment-2457949769, gurk/presage triggers https://github.com/signalapp/Signal-Android/blob/0891a161b2d2b5de819f98d829370a8f12e7c124/libsignal-service/src/main/java/org/whispersystems/signalservice/api/messages/EnvelopeContentValidator.kt#L195 ([DataMessage] Missing timestamp!) in other clients. I believe this to be due to libsignal-service-rs trying to synchronising ReceiptMessages https://github.com/whisperfish/libsignal-service-rs/blob/6401dc34872a5f0c2fba32c1f136d98ccf3dd418/src/sender.rs#L416, leaving not much more than the field unidentifiedStatus.