Empty Flexible content - Githubissues

Senexis commented 1 year ago

Currently, when viewing pages, the flexible content is empty.

Details

It seems to be caused by the recent changes for compatiblity with Nova 4.26, but I never had any issues in the first place with it, and now that a call to is_a() is replaced from \stdClass to Fluent, the detection for \stdClass instances is broken.

I don't quite know how or why I don't experience issues in Nova 4.26 with version <1.0.9, but I don't. My layouts still are instances of \stdClass, so removing the check from getMappedLayout in HasFlexible seems to break my installation (getMappedLayout returns null). Reverting back to version 1.0.8 fixes the issue and is fully compatible with my usecase in Nova 4.26.

For posterity and sake of completeness:

The output of get_class and class_parents are stdClass and [] respectively.
I am using protected $casts = ['content' => FlexibleCast::class] to cast the content.
This happens in both existing, newly seeded, and newly created pages.
I am using custom Layout classes, normally extending the Whitecube\NovaFlexibleContent\Layouts\Layout class, and only having the required fields.
Layout classes are registered using ->addLayout([Layout]::class).
I am editing a regular resource, not a custom tool like outl1ne/nova-settings.

Proposed fix

The recent commits removed the check for is_a($item, \stdClass) (HasFlexible.php:125 in 1.0.8). This should be added back in the same elseif as Fluent::class, probably (ex. elseif (is_a($item, Fluent::class) || is_a($item, \stdClass::class))). I am not sure (and not feasibly able to test) whether this breaks things for people that are experiencing issues with >=1.0.9 and 4.26, hence I am not able to comfortably Pull Request.