whitesnowx / pe

0 stars 0 forks source link

No Prompt for Impossible Dates #3

Open whitesnowx opened 7 months ago

whitesnowx commented 7 months ago

Steps to reproduce

  1. Adding any person
  2. Adding an event with either 30-02-2024 or 31-04-2024
Code ``` adde 1 n/Family Visit d/31-02-2024, 12:00 - 15:00 ```

Results

Expected
Actual

Rationale:

Suggestions

[!Note] Additionally, can implement checks for leap years.


nus-pe-bot commented 7 months ago

Team's Response

Hi, thanks for pointing this out! :3

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add invalid dates for event

[Events can accept invalid dates]

Description

In 2024, there is no such date as 31-02-2024, however the command does not show the error that this date is not valid

Expected

Application should throw an error, stating that the date is invalid.

Actual

Application accepted the date and created an event

Steps to Reproduce

  1. adde 1 n/Birthday d/30-02-2024

image.png


[original: nus-cs2103-AY2324S2/pe-interim#2291] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, thanks for pointing this out.

However, we have already identified this issue and have also put it down in our Planned Enhancements in our DG (See: Section 4.3)

For your convenience, we have added the screenshot of the relevant section below:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]