search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

ORCIDs provided in Tales should be validated #405

Open Xarthisius opened 4 years ago

Xarthisius commented 4 years ago

Otherwise we get:

Failed to create a deposition. Server returned: 400 Client Error: BAD REQUEST for url: https://sandbox.zenodo.org/api/deposit/depositions { "errors": [ { "field": "metadata.creators.0.orcid", "message": "Not a valid ORCID identifier." } ], "message": "Validation error.", "status": 400 }
ThomasThelen commented 4 years ago

I was hoping that the ORCID python library would have a method for validating IDs but it looks like they don't. The easiest way would be to just query ORCID with the ID and see check what comes back (time-costly). ORCID also has some information on how they're generated that can probably be reverse engineered to check the ID string.

ThomasThelen commented 3 years ago

Linking to #432. By requiring the user to connect their ORCID account we'll have a valid ORCID.

We know that the dataset creator has a valid ORCID because they're signed into Whole Tale. This user can add additional authors, including their ORCID. @Xarthisius do you think that for each author in the metadata, validate the ORCID? Or do you think that having at least one valid ORCID is enough.