Open dphiffer opened 6 years ago
Note that I manually adjusted the reversegeo centroid to fall within the US border:
"reversegeo:latitude":42.331139,
"reversegeo:longitude":-83.058014,
cc @stepps00 and @bcamper and @migurski since this seems relevant, directly or indirectly, to their interests.
So, I think there are two issues here:
Constituencies don't have any list of potential parents because they are fiddly and complicated and we just never got around to sorting that out - https://github.com/whosonfirst/whosonfirst-placetypes/blob/master/placetypes/constituency.json
This is triggering a logic "error" in py-mz-wof-hierarchy
because in order to ensure a (common) hierarchy a place needs to know who its ancestors are (so we don't assign a neighbourhood as part of a county's hierarchy, for example) which isn't really possible unless we have a list of possible parents:
I suppose we could either:
Discuss!
I think option 1 is a good starting point. If we wanted to make the logic more clever (which... no?) I would say it could change depending the value of wof:association
.
I suppose the commonality across all constituencies is country
at least until the United Nations takes over.
In the meantime making country
the default parent seems like a reasonable middle-ground for a first-pass.
The second-pass would be to define the ways that parent can be redefined by association. So that would mean:
"wof:parent": [ "country" ]
"ASSOCIATION:parent": [ "..." ]
in constituency.jsonwof:association
property and then look up parentage accordinglyDid we ever decide on wof:association
as the Boring Name to distinguish one constituency from another? @stepps00 ?
Discuss!
Constituency parents are going to be tricky, because they’re legally defined in different places. Congressional district counts are determined by the US Census, but the district borders are determined by states. Lower-level city or county districts are determined there. It seems like a concept that can float freely throughout the hierarchy.
The idea was to use wof:association
, wof:association_type
, and wof:association_era
properties to represent parentage for constituency records.
wof:association
- This would be country-specific, and represent what constituency branch the record is a part of. The US House of Representatives, for example, would be "us-house"
.
wof:association_type
- This would represent the type of association, bicameral
, unicameral
, etc.
wof:association_era
- This would represent the formal name of that association. An example would be "115th Congress"
.
These properties were added in as a "first pass" in this PR, but the details were never fully hammered out. This still doesn't solve the issue of figuring out the hierarchy for these records, though.
I think a good first step would be to update the US constituency records to include the region
parent, since that seems to be an easy enough task, then update the hierarchies with additional placetypes once that's complete.
Tagging @burritojustice because he created a nice, detailed flowchart for various constituency records at some point...
Given all of the above:
country
as the minimal viable parent for a constituency?[ "region", "country" ]
?
Here's a simple test that demonstrates an issue I've encountered trying to PIP constituency record 1108767273:
Output: