search

whosonfirst / whosonfirst-www-boundaryissues

Boundary Issues is a web-application for editing Who's On First data.
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

tags and addresses for existing venues are getting overwritten when a record is updated #329

Open burritojustice opened 7 years ago

burritojustice commented 7 years ago

see:

https://github.com/whosonfirst-data/whosonfirst-data-venue-us-ca/commit/a609060d08bb4e9afde678d5eff32dd1d98640d9#diff-faf3b586ad481f7e754cbfab70b36b07L86

better feedback of what will happen when a record is to be updated would be very helpful (even if it's just a text summary). Showing more data that is in place would be useful in making a decision whether a record should in fact be updated.

For context, my primary intent was to improve the location of existing records. I had assumed that adding tags would not overwrite existing tags but be added to the list. I also didn't realize that existing address info was being overwritten -- from the UI perspective it seemed that the addr:full field was empty and I was adding new info, whereas I was in fact overwriting it...

dphiffer commented 7 years ago

Oh, I think I've fixed this one (see also: #247).

Can you confirm that you're still seeing the behavior? Otherwise, I think we can close.

burritojustice commented 7 years ago

just tried here. original tag was baker, I added bakery. I only see the latter in BI, still see baker in the Spelunker.

https://whosonfirst.mapzen.com/spelunker/id/572019619/ https://whosonfirst.mapzen.com/boundaryissues/id/572019619#16/37.7428/-122.4782

don't see it in Github yet. https://github.com/whosonfirst-data/whosonfirst-data-venue-us-ca/tree/master/data

dphiffer commented 7 years ago

Yeah, I can replicate it. Still not fixed after all.

dphiffer commented 7 years ago

This should be fixed now. There were two remaining issues:

  1. I forgot to restart the geojson pony after deploying the fix
  2. The address value was still getting clobbered