whosonfirst / whosonfirst-www-boundaryissues

Boundary Issues is a web-application for editing Who's On First data.
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Hierarchies are still weird #332

Open dphiffer opened 7 years ago

dphiffer commented 7 years ago

I've noticed a handful of weird things happening with hierarchy/parent assignment in BI. This is a catch-all issue to account for them.

stepps00 commented 7 years ago

I added reversegeo:* properties to the record of Basse Terre and update the record's hierarchy, here. This worked as expected, but the wof:parent_id was not reset. I think this touches the first point, "make the wof:parent_id field writeable".

stepps00 commented 7 years ago

https://whosonfirst.mapzen.com/boundaryissues/id/1158844415/#16/37.3144/-121.8657

I added this record via BI and it received a dual hierarchy:

'wof:hierarchy': [{u'continent_id': 102191575,
                     u'country_id': 85633793,
                     u'county_id': 102081673,
                     u'locality_id': 85922347,
                     u'macrohood_id': 1108782557,
                     u'neighbourhood_id': 1108784971,
                     u'region_id': 85688637,
                     u'venue_id': 1158844415},

                    {u'continent_id': 102191575,
                     u'country_id': 85633793,
                     u'county_id': 102081673,
                     u'locality_id': 85922347,
                     u'neighbourhood_id': 85887655,  <--
                     u'region_id': 85688637,
                     u'venue_id': 1158844415}],

The second hierarchy includes a deprecated/non-current neighbourhood record. The first hierarchy is correct, but records tagged as non-current shouldn't be used to build hierarchies.

stepps00 commented 7 years ago

Noting that the wof:parent_id property is now editable, but not re-populated when a hierarchy is rebuilt.