search

whosonfirst / whosonfirst-www-boundaryissues

Boundary Issues is a web-application for editing Who's On First data.
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

BI updating non-edited properties #334

Open stepps00 opened 7 years ago

stepps00 commented 7 years ago

See: https://github.com/whosonfirst-data/whosonfirst-data/commit/7ec6f59b64ac455112ad68ca5986532b08f97455

I edited the wof:country and iso:country property values through Boundary Issues, but other properties that I did not update were also changed in the same commit.

thisisaaronland commented 7 years ago

Like what?

dphiffer commented 7 years ago

I see two things happening:

thisisaaronland commented 7 years ago

I am more concerned with null values because 1. we are removing keys that shouldn't removed and 2. we shouldn't have null values to start with - they should encoded as empty strings.

Stripping floating point values of their decimal points is not awesome. Most of what I'm seeing in that diff look like values that were exported out of that just defaulted to floats, where an int would have sufficed, but the larger issue is there may well be a case where a field needs to be a float and may have legitimate reason to keep the trailing 0.

stepps00 commented 7 years ago

Just echoing https://github.com/whosonfirst/whosonfirst-www-boundaryissues/issues/334#issuecomment-334597795 - floats are being turned into integers and null values are being removed. Relevant: https://github.com/whosonfirst/whosonfirst-www-boundaryissues/issues/299

the larger issue is there may well be a case where a field needs to be a float and may have legitimate reason to keep the trailing 0.

This is a good point, and could be a potential issue when joining data on a property with a decimal value.